Page MenuHomeWickedGov Phorge
Files F5970025

AddMissingLoggingEntries.php
No OneTemporary
Actions

Size
4 KB
Referenced Files
None
Subscribers
None

AddMissingLoggingEntries.php
View Options

<?php
namespace MediaWiki\Extension\AbuseFilter\Maintenance;
// @codeCoverageIgnoreStart
$IP = getenv( 'MW_INSTALL_PATH' );
if ( $IP === false ) {
$IP = __DIR__ . '/../../..';
}
require_once "$IP/maintenance/Maintenance.php";
// @codeCoverageIgnoreEnd
use MediaWiki\Extension\AbuseFilter\Special\SpecialAbuseFilter;
use MediaWiki\Logging\ManualLogEntry;
use MediaWiki\Maintenance\LoggedUpdateMaintenance;
use MediaWiki\User\UserIdentityValue;
use Wikimedia\Rdbms\IExpression;
use Wikimedia\Rdbms\LikeValue;
/**
* @codeCoverageIgnore
* No need to test old single-use script.
*/
class AddMissingLoggingEntries extends LoggedUpdateMaintenance {
public function __construct() {
parent::__construct();
$this->addDescription( 'Add missing logging entries for abusefilter-modify T54919' );
$this->addOption( 'dry-run', 'Perform a dry run' );
$this->addOption( 'verbose', 'Print a list of affected afh_id' );
$this->requireExtension( 'Abuse Filter' );
}
/**
* @inheritDoc
*/
public function getUpdateKey() {
return 'AddMissingLoggingEntries';
}
/**
* @inheritDoc
*/
public function doDBUpdates() {
$dryRun = $this->hasOption( 'dry-run' );
$logParams = [];
$afhRows = [];
$db = $this->getDB( DB_REPLICA, 'vslow' );
$logParamsConcat = $db->buildConcat( [ 'afh_id', $db->addQuotes( "\n" ) ] );
$legacyParamsLike = new LikeValue( $logParamsConcat, $db->anyString() );
// Non-legacy entries are a serialized array with 'newId' and 'historyId' keys
$newLogParamsLike = new LikeValue( $db->anyString(), 'historyId', $db->anyString() );
// Find all entries in abuse_filter_history without logging entry of same timestamp
$afhResult = $db->newSelectQueryBuilder()
->select( [ 'afh_id', 'afh_filter', 'afh_timestamp', 'afh_deleted', 'actor_user', 'actor_name' ] )
->from( 'abuse_filter_history' )
->join( 'actor', null, [ 'actor_id = afh_actor' ] )
->leftJoin( 'logging', null, [
'afh_timestamp = log_timestamp',
$db->expr( 'log_params', IExpression::LIKE, $legacyParamsLike ),
'log_type' => 'abusefilter',
] )
->where( [
'log_id' => null,
$db->expr( 'log_params', IExpression::NOT_LIKE, $newLogParamsLike ),
] )
->caller( __METHOD__ )
->fetchResultSet();
// Because the timestamp matches aren't exact (sometimes a couple of
// seconds off), we need to check all our results and ignore those that
// do actually have log entries
foreach ( $afhResult as $row ) {
$logParams[] = $row->afh_id . "\n" . $row->afh_filter;
$afhRows[$row->afh_id] = $row;
}
if ( !count( $afhRows ) ) {
$this->output( "Nothing to do.\n" );
return !$dryRun;
}
$logResult = $this->getDB( DB_REPLICA )->newSelectQueryBuilder()
->select( 'log_params' )
->from( 'logging' )
->where( [ 'log_type' => 'abusefilter', 'log_params' => $logParams ] )
->caller( __METHOD__ )
->fetchFieldValues();
foreach ( $logResult as $params ) {
// id . "\n" . filter
$afhId = explode( "\n", $params, 2 )[0];
// Forget this row had any issues - it just has a different timestamp in the log
unset( $afhRows[$afhId] );
}
if ( !count( $afhRows ) ) {
$this->output( "Nothing to do.\n" );
return !$dryRun;
}
if ( $dryRun ) {
$msg = count( $afhRows ) . " rows to insert.";
if ( $this->hasOption( 'verbose' ) ) {
$msg .= " Affected IDs (afh_id):\n" . implode( ', ', array_keys( $afhRows ) );
}
$this->output( "$msg\n" );
return false;
}
$dbw = $this->getDB( DB_PRIMARY );
$count = 0;
foreach ( $afhRows as $row ) {
if ( $count % 100 === 0 ) {
$this->waitForReplication();
}
$user = new UserIdentityValue( (int)( $row->actor_user ?? 0 ), $row->actor_name );
// This copies the code in FilterStore
$logEntry = new ManualLogEntry( 'abusefilter', 'modify' );
$logEntry->setPerformer( $user );
$logEntry->setTarget( SpecialAbuseFilter::getTitleForSubpage( $row->afh_filter ) );
// Use the new format!
$logEntry->setParameters( [
'historyId' => $row->afh_id,
'newId' => $row->afh_filter
] );
$logEntry->setTimestamp( $row->afh_timestamp );
$logEntry->insert( $dbw );
$count++;
}
$this->output( "Inserted $count rows.\n" );
return true;
}
}
$maintClass = AddMissingLoggingEntries::class;
require_once RUN_MAINTENANCE_IF_MAIN;

File Metadata

Mime Type
text/x-php
Expires
Sat, Oct 3, 14:10 (12 h, 53 m ago)
Storage Engine
local-disk
Storage Format
Raw Data
Storage Handle
0b/0c/a24c861d31246aefc4590e2f3b45
Default Alt Text
AddMissingLoggingEntries.php (4 KB)

Event Timeline