OverlayManager.test.js
No OneTemporary
Actions

Size

15 KB

Referenced Files

None

Subscribers

None

OverlayManager.test.js
View Options

	/* global $ */
	const
	sinon = require( 'sinon' ),
	dom = require( '../utils/dom' ),
	jQuery = require( '../utils/jQuery' ),
	oo = require( '../utils/oo' ),
	util = require( '../../../src/mobile.startup/util' ),
	mediaWiki = require( '../utils/mw' ),
	mustache = require( '../utils/mustache' );
	let
	OverlayManager, Overlay,
	fakeRouter,
	overlayManager,
	routeEvent,
	sandbox;

	QUnit.module( 'MobileFrontend mobile.startup/OverlayManager', {
	beforeEach: function () {
	sandbox = sinon.sandbox.create();
	dom.setUp( sandbox, global );
	oo.setUp( sandbox, global );
	jQuery.setUp( sandbox, global );
	mediaWiki.setUp( sandbox, global );
	mustache.setUp( sandbox, global );

	// jsdom will throw "Not implemented" errors if we don't stub
	// window.scrollTo
	sandbox.stub( global.window, 'scrollTo' );

	OverlayManager = require( '../../../src/mobile.startup/OverlayManager' );
	Overlay = require( '../../../src/mobile.startup/Overlay' );
	routeEvent = function ( data ) {
	return $.Event( 'route', data );
	};

	this.createFakeOverlay = function ( options ) {
	const fakeOverlay = new OO.EventEmitter();
	fakeOverlay.show = sandbox.spy();
	fakeOverlay.hide = function () {
	this.emit( 'hide' );
	return true;
	};
	fakeOverlay.$el = util.parseHTML( '<div>' );
	sandbox.spy( fakeOverlay, 'hide' );
	util.extend( fakeOverlay, options );
	return fakeOverlay;
	};

	fakeRouter = new OO.EventEmitter();
	fakeRouter.getPath = () => '';
	fakeRouter.back = sandbox.spy();
	const requireStub = sandbox.stub();
	/* eslint-disable-next-line camelcase */
	global.__non_webpack_require__ = requireStub;
	requireStub.withArgs( 'mediawiki.router' ).returns( fakeRouter );
	overlayManager = new OverlayManager( fakeRouter, document.body );
	OverlayManager.test.__clearCache();
	},
	afterEach: function () {
	jQuery.tearDown();
	sandbox.restore();
	}
	} );

	QUnit.test( '#getSingleton (hash present and overlay not managed)', function ( assert ) {
	const spy = sandbox.spy( window.history, 'replaceState' );

	sandbox.stub( fakeRouter, 'getPath' ).returns( '#/editor/0' );
	const singleton = OverlayManager.getSingleton();
	assert.true( singleton instanceof OverlayManager, 'singleton exists' );
	assert.strictEqual( spy.calledOnce, true,
	'If a page is loaded with a hash fragment a new entry is placed before it to allow the user to go back.' );
	} );

	QUnit.test( '#getSingleton (hash present and overlay managed)', function ( assert ) {
	// replace the current URL before the test
	window.history.replaceState( OverlayManager.test.MANAGED_STATE, null, window.location.href );
	const spy = sandbox.spy( window.history, 'replaceState' );

	sandbox.stub( fakeRouter, 'getPath' ).returns( '#/editor/0' );
	OverlayManager.getSingleton();
	assert.strictEqual( spy.calledOnce, false,
	'If the history entry was added/removed by overlay manager, no URI correct occurs.' );
	} );

	QUnit.test( '#getSingleton', function ( assert ) {
	const singleton = OverlayManager.getSingleton();
	assert.true( singleton instanceof OverlayManager, 'singleton exists' );
	assert.strictEqual( singleton, OverlayManager.getSingleton(), 'same object returned each time' );
	} );

	QUnit.test( '#add', function ( assert ) {
	const fakeOverlay = this.createFakeOverlay();

	overlayManager.add( /^test$/, function () {
	return fakeOverlay;
	} );
	fakeRouter.emit( 'route', {
	path: 'test'
	} );

	assert.strictEqual( fakeOverlay.show.callCount, 1, 'show registered overlay' );
	} );

	QUnit.test( '#show', function ( assert ) {
	const fakeOverlay = this.createFakeOverlay(),
	showSpy = sandbox.spy( overlayManager, '_show' );

	overlayManager.add( /^showTest$/, function () {
	return fakeOverlay;
	} );
	fakeRouter.emit( 'route', {
	path: 'showTest'
	} );

	assert.strictEqual( showSpy.callCount, 1, 'OverlayManager.show called on route change' );
	} );

	QUnit.test( '#add, with current path', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	deferred = util.Deferred();
	fakeRouter.getPath = sandbox.stub().returns( 'baha' );

	overlayManager.add( /^baha$/, function () {
	return fakeOverlay;
	} );

	// Wait for $.ready because OverlayManager#add() does
	util.docReady( function () {
	deferred.resolve();
	} );

	return deferred.then( function () {
	assert.strictEqual( fakeOverlay.show.callCount, 1, 'show registered overlay' );
	} );
	} );

	QUnit.test( '#add, with string literal (matching)', function ( assert ) {
	const deferred = util.Deferred(),
	fakeOverlay = this.createFakeOverlay();
	deferred.show = sandbox.spy();

	// Note: In this test, we also test if OverlayManager will try to do regex
	// operations (e.g. ''.match()) on a string literal (which would cause an
	// error since this is an invalid regex (Unterminated character)
	// eslint-disable-next-line no-useless-escape
	overlayManager.add( '[.*+?^${}()\|[\][(foo)', function () {
	return fakeOverlay;
	} );
	fakeRouter.emit( 'route', {
	// eslint-disable-next-line no-useless-escape
	path: '[.*+?^${}()\|[\][(foo)'
	} );
	deferred.resolve( fakeOverlay );

	return deferred.then( function () {
	assert.strictEqual( fakeOverlay.show.callCount, 1, 'show called for string that matches' );
	} );
	} );

	QUnit.test( '#add, with string literal (not matching)', function ( assert ) {
	const deferred = util.Deferred(),
	fakeOverlay = this.createFakeOverlay();
	deferred.show = sandbox.spy();

	// eslint-disable-next-line no-useless-escape
	overlayManager.add( '[.*+?^${}()\|[\](foo)', function () {
	return deferred;
	} );
	fakeRouter.emit( 'route', {
	path: '(bar)'
	} );
	deferred.resolve( fakeOverlay );

	return deferred.then( function () {
	assert.strictEqual( fakeOverlay.show.callCount, 0, 'show not called for string that doesn\'t match' );
	} );
	} );

	QUnit.test( '#replaceCurrent', function ( assert ) {
	const overlayManagerEmpty = new OverlayManager( fakeRouter, document.body ),
	fakeOverlay = this.createFakeOverlay(),
	anotherFakeOverlay = this.createFakeOverlay();

	assert.throws( () => {
	overlayManagerEmpty.replaceCurrent( {} );
	}, 'throws exceptions if you replace an empty stack' );

	overlayManager.add( /^test$/, function () {
	return fakeOverlay;
	} );

	fakeRouter.emit( 'route', {
	path: 'test'
	} );
	overlayManager.replaceCurrent( anotherFakeOverlay );
	assert.strictEqual( fakeOverlay.hide.callCount, 1, 'hide overlay' );
	assert.strictEqual( anotherFakeOverlay.show.callCount, 1, 'show another overlay' );
	fakeRouter.emit( 'route', {
	path: ''
	} );
	assert.strictEqual( anotherFakeOverlay.hide.callCount, 1, 'hide another overlay' );
	} );

	QUnit.test( 'route with params', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	factoryStub = sandbox.stub().returns( fakeOverlay );

	overlayManager.add( /^sam\/(\d+)$/, factoryStub );
	fakeRouter.emit( 'route', {
	path: 'sam/123'
	} );

	assert.true( factoryStub.calledWith( '123' ), 'pass params from the route' );
	} );

	QUnit.test( 'hide when route changes', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	factoryStub = sandbox.stub().returns( fakeOverlay );

	overlayManager.add( /^jon$/, factoryStub );
	fakeRouter.emit( 'route', {
	path: 'jon'
	} );
	fakeRouter.emit( 'route', {
	path: ''
	} );
	fakeRouter.emit( 'route', {
	path: 'jon'
	} );
	fakeRouter.emit( 'route', {
	path: 'other'
	} );

	assert.strictEqual( fakeOverlay.hide.callCount, 2, 'hide overlay' );
	assert.true( fakeOverlay.hide.getCall( 0 ).notCalledWith( true ), 'don\'t force hide (first)' );
	assert.true( fakeOverlay.hide.getCall( 1 ).notCalledWith( true ), 'don\'t force hide (second)' );
	} );

	QUnit.test( 'go back (change route) if overlay hidden but not by route change', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	factoryStub = sandbox.stub().returns( fakeOverlay );

	overlayManager.add( /^joakino$/, factoryStub );
	fakeRouter.emit( 'route', {
	path: 'joakino'
	} );
	sandbox.stub( fakeRouter, 'getPath' ).returns( 'joakino' );

	// Call hide outside OverlayManager
	fakeOverlay.hide();

	assert.strictEqual( fakeRouter.back.callCount, 1, 'route back is called' );
	} );

	QUnit.test( 'go back if overlayManager still matches', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	factoryStub = sandbox.stub().returns( fakeOverlay );

	overlayManager.add( /^media\/(.*)$/, factoryStub );
	fakeRouter.emit( 'route', {
	path: 'media/foo'
	} );
	// Something updates the path e.g. history.replaceState - but it still matches
	// the current overlay pattern.
	sandbox.stub( fakeRouter, 'getPath' ).returns( 'media/bar' );

	// Call hide outside OverlayManager
	fakeOverlay.hide();

	assert.strictEqual( fakeRouter.back.callCount, 1, 'route back is called' );
	} );

	QUnit.test( 'go back if overlayManager still matches (non-regex)', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	factoryStub = sandbox.stub().returns( fakeOverlay );

	// Note ^foo$ is not a regex - it's a string. This is the important part of the test.
	// as String.match if passed a non-regex will turn it into a regex.
	overlayManager.add( '^foo$', factoryStub );
	// the overlay manager route is triggered and the factoryStub overlay is shown
	fakeRouter.emit( 'route', {
	path: '^foo$'
	} );
	// Something updates the path e.g. history.replaceState - but it still matches
	// the current overlay pattern.
	sandbox.stub( fakeRouter, 'getPath' ).onCall( 0 ).returns( '^foo$' )
	// On 2nd case, pretend something called replaceState set #foo
	// if the overlayManager had defined a __regex__ route, this would match,
	// however the route is NOT a regex so the route has been changed.
	.onCall( 1 ).returns( 'foo' );
	// Call hide outside OverlayManager with route at #^foo$
	fakeOverlay.hide();

	assert.strictEqual( fakeRouter.back.callCount, 1, 'route back is called' );

	// load the overlay again via a URL change.
	fakeRouter.emit( 'route', {
	path: '^foo$'
	} );

	// Call hide outside OverlayManager with route at #foo
	fakeOverlay.hide();

	assert.strictEqual( fakeRouter.back.callCount, 2, 'and route back is called again' );

	} );

	QUnit.test( 'do not go back (change route) if overlay hidden by change in route', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	factoryStub = sandbox.stub().returns( fakeOverlay );

	overlayManager.add( /^joakino$/, factoryStub );
	// set the router to joakino
	fakeRouter.emit( 'route', {
	path: 'joakino'
	} );
	// Let's pretend something outside the router sets the address bar to a #section_anchor...
	// now any calls to getPath will return section_anchor
	sandbox.stub( fakeRouter, 'getPath' ).returns( 'section_anchor' );
	// something outside the overlay manager calls hide.
	fakeOverlay.hide();
	assert.strictEqual( fakeRouter.back.callCount, 0,
	'route back is not called if the hash has already changed from what it was for the overlay' );
	} );

	QUnit.test( 'preventDefault called when you cancel an exit request', function ( assert ) {
	const $container = util.parseHTML( '<div>' ),
	manager = new OverlayManager( fakeRouter, $container[ 0 ] ),
	backEvent = routeEvent( { path: '' } ),
	backEventPreventDefaultSpy = sandbox.spy( backEvent, 'preventDefault' );

	manager.add( /^canceloverlay$/, function () {
	return new Overlay( {
	onBeforeExit: function ( _exit, cancel ) {
	cancel();
	}
	} );
	} );
	fakeRouter.emit( 'route', routeEvent( { path: 'canceloverlay' } ) );
	// try to go back.
	fakeRouter.emit( 'route', backEvent );

	assert.strictEqual( backEventPreventDefaultSpy.calledOnce, true,
	'Prevent default was called when the user attempted to go back, preventing an address bar change.' );
	} );

	QUnit.test( 'Browser back can be overidden', function ( assert ) {
	const escapableOverlay = new Overlay( {} ),
	done = assert.async(),
	$container = util.parseHTML( '<div>' ),
	cannotGoBackOverlay = new Overlay( {
	onBeforeExit: function () {}
	} ),
	manager = new OverlayManager( fakeRouter, $container[ 0 ] );

	// define 2 routes
	manager.add( /^proceed$/, function () {
	return escapableOverlay;
	} );
	manager.add( /^youcannotpass$/, function () {
	return cannotGoBackOverlay;
	} );
	fakeRouter.emit( 'route', routeEvent( { path: 'proceed' } ) );
	assert.strictEqual( $container.find( escapableOverlay.$el ).length, 1,
	'escapable overlay is displayed' );
	fakeRouter.emit( 'route', routeEvent( { path: 'youcannotpass' } ) );
	// emitting route will trigger the display of an overlay associated with the path.
	// showing is an asynchronous process controlled via setTimeout
	// hence this is an asynchronous test.
	setTimeout( () => {
	assert.strictEqual( $container.find( escapableOverlay.$el ).length, 0,
	'escapable overlay is no longer displayed' );
	assert.strictEqual( $container.find( cannotGoBackOverlay.$el ).length, 1,
	'cannot go back overlay is now the overlay on display' );
	// attempt to go back
	fakeRouter.emit( 'route', routeEvent( { path: 'proceed' } ) );
	setTimeout( () => {
	assert.strictEqual( $container.find( cannotGoBackOverlay.$el ).length, 1,
	'cannot go back overlay is still the overlay on display (cannot exit!)' );
	assert.strictEqual( $container.find( escapableOverlay.$el ).length, 0,
	'Escapeable overlay is not displayed' );
	assert.strictEqual( manager.stack[0].overlay, cannotGoBackOverlay,
	'Cannot go back overlay remains on the top of the stack' );
	done();
	}, 0 );
	}, 0 );
	} );

	QUnit.test( 'stacked overlays', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay(),
	factoryStub = sandbox.stub().returns( fakeOverlay ),
	parentFakeOverlay = this.createFakeOverlay(),
	parentFactoryStub = sandbox.stub().returns( parentFakeOverlay );

	overlayManager.add( /^parent$/, parentFactoryStub );
	overlayManager.add( /^child$/, factoryStub );

	fakeRouter.emit( 'route', {
	path: 'parent'
	} );
	assert.strictEqual( parentFakeOverlay.show.callCount, 1, 'show parent' );
	fakeRouter.emit( 'route', {
	path: 'child'
	} );
	assert.strictEqual( parentFakeOverlay.hide.callCount, 1, 'hide parent' );
	assert.strictEqual( fakeOverlay.show.callCount, 1, 'show child' );
	fakeRouter.emit( 'route', {
	path: 'parent'
	} );
	assert.strictEqual( fakeOverlay.hide.callCount, 1, 'hide child' );
	assert.strictEqual( parentFakeOverlay.show.callCount, 2, 'show parent again' );

	assert.strictEqual( parentFactoryStub.callCount, 1, 'create parent only once' );
	} );

	QUnit.test( 'prevent route change', function ( assert ) {
	const
	fakeOverlay = this.createFakeOverlay( {
	hide: sandbox.stub().returns( false )
	} ),
	factoryStub = sandbox.stub().returns( fakeOverlay ),
	ev = {
	path: '',
	preventDefault: sandbox.spy()
	};

	overlayManager.add( /^rob$/, factoryStub );

	fakeRouter.emit( 'route', {
	path: 'rob'
	} );
	fakeRouter.emit( 'route', ev );
	assert.strictEqual( ev.preventDefault.called, false,
	'Previously extending hide could prevent closes, this behaviour changed in I2668b6e54a6d54e820d60e4b56028338908ad55f' );
	} );

	QUnit.test( 'stack increases and decreases at right times', function ( assert ) {
	const self = this;

	overlayManager.add( /^test\/(\d+)$/, function () {
	return self.createFakeOverlay();
	} );
	fakeRouter.emit( 'route', {
	path: 'test/0'
	} );

	assert.strictEqual( overlayManager.stack.length, 1, 'stack is correct size' );

	fakeRouter.emit( 'route', {
	path: 'test/1'
	} );

	assert.strictEqual( overlayManager.stack.length, 2, 'stack is correct size' );

	fakeRouter.emit( 'route', {
	path: 'test/0'
	} );

	assert.strictEqual( overlayManager.stack.length, 1, 'stack decreases when going back to already visited overlay' );
	} );

	QUnit.test( 'replace overlay when route event path is equal to current path', function ( assert ) {
	const self = this;

	overlayManager.add( /^test\/(\d+)$/, function () {
	return self.createFakeOverlay();
	} );
	fakeRouter.emit( 'route', {
	path: 'test/0'
	} );

	assert.strictEqual( overlayManager.stack.length, 1, 'stack is correct size' );

	fakeRouter.emit( 'route', {
	path: 'test/0'
	} );

	assert.strictEqual( overlayManager.stack.length, 1, 'stack is correct size (did not increase upon reload)' );
	} );

File Metadata

Mime Type: text/plain
Expires: Fri, Jul 3, 19:25 (1 d, 7 h)
Storage Engine: local-disk
Storage Format: Raw Data
Storage Handle: 55/8b/d475218f8fd2742b9796e1408fef
Default Alt Text: OverlayManager.test.js (15 KB)

OverlayManager.test.jsNo OneTemporaryActions

OverlayManager.test.jsView Options

File Metadata

Event Timeline

OverlayManager.test.js
No OneTemporary
Actions

OverlayManager.test.js
View Options